Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Do you have any files from climate models or similar that you should showcase in this notebook? I'm not sure if showcasing the multipoly.shp is relevant to our users, as it isn't a proper grid.

Do you have any files from climate models or similar that you should showcase in this notebook? I'm not sure if showcasing the multipoly.shp is relevant to our users, as it isn't a proper grid.

yes, this PR is work in progress. I'll make it a draft.

What about the following title & description?

Title

Reading & Working with Geometry Files

Description

Load and work with geometry files (i.e. Shapefile, GeoJSON)

Is GIS more accurate? (it's gray area as we may also call it geometry in the sense that they store spatial data, such as the shapes, boundaries, and locations of features on the Earth’s surface.

What about the following title & description?

Title

Reading & Working with Geometry Files

Description

Load and work with geometry files (i.e. Shapefile, GeoJSON)

Is GIS more accurate? (it's gray area as we may also call it geometry in the sense that they store spatial data, such as the shapes, boundaries, and locations of features on the Earth’s surface.

It might be a bit more accurate, but GIS seems pretty outside of the scope of our package.

What about the following title & description?

Title

Reading & Working with Geometry Files

Description

Load and work with geometry files (i.e. Shapefile, GeoJSON)

Is GIS more accurate? (it's gray area as we may also call it geometry in the sense that they store spatial data, such as the shapes, boundaries, and locations of features on the Earth’s surface.

It might be a bit more accurate, but GIS seems pretty outside of the scope of our package.

Ok, since we explicitly call the formats, I have changed it to geometry files "Shapefile, GeoJSON"

I think you forgot to clear the cell output and restart the kernel of the notebook before pushing the changes. Also, there seems to be an error in the docs.

Thanks, yes. I'm looking to fix this.

View / edit / reply to this conversation on ReviewNB

philipc2 commented on 2025-01-10T23:58:00Z
----------------------------------------------------------------

I would suggest simplifying the introduction to the following (can exclude the first half):

This notebooks demonstrates how to use the Grid.from_file() class method to load in geometry files such as:

1. Shapefile
2. GeoJSON

Highlighted is a workflow showcasing how to remap a variable from an unstructured grid to a Shapefile.

View / edit / reply to this conversation on ReviewNB

philipc2 commented on 2025-01-10T23:58:00Z
----------------------------------------------------------------

Please refer to the from_file function as Grid.from_file()

View / edit / reply to this conversation on ReviewNB

philipc2 commented on 2025-01-10T23:58:01Z
----------------------------------------------------------------

Grid.from_file()

View / edit / reply to this conversation on ReviewNB

philipc2 commented on 2025-01-10T23:58:02Z
----------------------------------------------------------------

Check the markdown heading; the size appears to be off. Please make sure the following is applied throughout:

• "#": Only used for the title
• "##" Used for major headings (such as this one)
• "###" Used for any smaller sub-headings.